Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1311 datetime comparision #1317

Closed
wants to merge 7 commits into from

Conversation

Projects
None yet
4 participants
@sh286
Copy link
Member

commented Dec 9, 2013

Fixing #1311

sh286 added some commits Dec 8, 2013

Adding comment to explain how the Date works in Java (Using JODA Time…
… lib) and how it should work in Ruby to keep the mri compatiblity
Comparing two DateTimes (and sub milliseconds) using <=> and returnin…
…g -1, 0, or +1 depending

on whether the receiver is less than, equal to, or greater than the
other object.
@sh286

This comment has been minimized.

Copy link
Member Author

commented Dec 9, 2013

@Sinjo done! Thanks!

@Sinjo

This comment has been minimized.

Copy link
Contributor

commented Dec 9, 2013

@lucasallan Awesome, cool to see it fixed. Probably worth making sure these commits get applied (haven't looked if they just apply cleanly, suspect they may not due to path changes) on the jruby-1_7 branch so they go into the next 1.7.x patch release. :-)

@sh286

This comment has been minimized.

Copy link
Member Author

commented Dec 9, 2013

@Sinjo Sounds great. Thanks :D

@headius

This comment has been minimized.

Copy link
Member

commented Dec 10, 2013

If this should go into 1.7, it might be better to reapply the fixes to 1.7, since we merge from there to master.

We can also merge this and then do a second PR for the 1.7 branch, but it makes the merge logs a little weird.

@headius

This comment has been minimized.

Copy link
Member

commented Dec 10, 2013

Actually, I managed to cherry-pick all commits just fine, and will run some local tests. If all is well, I'll push, merge to master, and call this one done.

@sh286

This comment has been minimized.

Copy link
Member Author

commented Dec 10, 2013

Thanks @headius :D

@headius

This comment has been minimized.

Copy link
Member

commented Dec 10, 2013

Cherry-picked to jruby-1_7 up to b11ad9a and merged to master at 11ee84b.

I also fixed the misspelling in the test name and will commit that to MRI trunk.

@headius headius closed this Dec 10, 2013

@sh286

This comment has been minimized.

Copy link
Member Author

commented Dec 10, 2013

@headius Sorry about it, english isn't my native language.

@headius

This comment has been minimized.

Copy link
Member

commented Dec 10, 2013

No problem :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.