Fixing Enumerator#peek behaviour #1336

Merged
merged 1 commit into from Dec 15, 2013

Projects

None yet

2 participants

@lucasallan
Member

@enebo I closed the old pull request and opened this one to be merged on jruby-1_7 as you asked.

@lucasallan lucasallan Fixing Enumerator#peek behaviour. When the Enumerator position is alr…
…eady at the end and method peek is called then JRuby was throwing a NullPointerException. But the correct behaviour should be raise a StopIteration.
c7e9d05
@enebo enebo merged commit 2e7054b into jruby:jruby-1_7 Dec 15, 2013

1 check failed

default The Travis CI build could not complete due to an error
Details
@enebo
Member
enebo commented Dec 15, 2013

Thanks Lucas, I should have mentioned that test/externals/ruby1.9 is actually MRI's 1.9 test suite. I committed it anyways but if we ever resync your test will disappear (which I think is fine so long as you open an issue and get this test added to MRI or rubyspecs test suite).

@lucasallan
Member

@enebo thanks you very much. I sent a pul request to mri with these tests ruby/ruby#479

@lucasallan lucasallan deleted the unknown repository branch Dec 15, 2013
@enebo enebo modified the milestone: JRuby 1.7.10, JRuby 1.7.11 Feb 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment