Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Enumerator#peek behaviour #1336

Merged
merged 1 commit into from Dec 15, 2013

Conversation

Projects
None yet
2 participants
@sh286
Copy link
Member

sh286 commented Dec 14, 2013

@enebo I closed the old pull request and opened this one to be merged on jruby-1_7 as you asked.

Fixing Enumerator#peek behaviour. When the Enumerator position is alr…
…eady at the end and method peek is called then JRuby was throwing a NullPointerException. But the correct behaviour should be raise a StopIteration.

enebo added a commit that referenced this pull request Dec 15, 2013

Merge pull request #1336 from lucasallan/enumerator-peek
Fixing Enumerator#peek behaviour

@enebo enebo merged commit 2e7054b into jruby:jruby-1_7 Dec 15, 2013

1 check failed

default The Travis CI build could not complete due to an error
Details
@enebo

This comment has been minimized.

Copy link
Member

enebo commented Dec 15, 2013

Thanks Lucas, I should have mentioned that test/externals/ruby1.9 is actually MRI's 1.9 test suite. I committed it anyways but if we ever resync your test will disappear (which I think is fine so long as you open an issue and get this test added to MRI or rubyspecs test suite).

@sh286

This comment has been minimized.

Copy link
Member Author

sh286 commented Dec 15, 2013

@enebo thanks you very much. I sent a pul request to mri with these tests ruby/ruby#479

@sh286 sh286 deleted the sh286:enumerator-peek branch Dec 15, 2013

@enebo enebo modified the milestones: JRuby 1.7.10, JRuby 1.7.11 Feb 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.