Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Enumerator#peek behaviour #1336

Merged
merged 1 commit into from Dec 15, 2013
Merged

Fixing Enumerator#peek behaviour #1336

merged 1 commit into from Dec 15, 2013

Conversation

@lucasallan
Copy link
Member

@lucasallan lucasallan commented Dec 14, 2013

@enebo I closed the old pull request and opened this one to be merged on jruby-1_7 as you asked.

…eady at the end and method peek is called then JRuby was throwing a NullPointerException. But the correct behaviour should be raise a StopIteration.
enebo added a commit that referenced this pull request Dec 15, 2013
@enebo enebo merged commit 2e7054b into jruby:jruby-1_7 Dec 15, 2013
1 check failed
1 check failed
@enebo
default The Travis CI build could not complete due to an error
Details
@enebo
Copy link
Member

@enebo enebo commented Dec 15, 2013

Thanks Lucas, I should have mentioned that test/externals/ruby1.9 is actually MRI's 1.9 test suite. I committed it anyways but if we ever resync your test will disappear (which I think is fine so long as you open an issue and get this test added to MRI or rubyspecs test suite).

@lucasallan
Copy link
Member Author

@lucasallan lucasallan commented Dec 15, 2013

@enebo thanks you very much. I sent a pul request to mri with these tests ruby/ruby#479

@lucasallan lucasallan deleted the lucasallan:enumerator-peek branch Dec 15, 2013
@enebo enebo modified the milestones: JRuby 1.7.10, JRuby 1.7.11 Feb 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants