Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ffi buffer #1412

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
3 participants
@tduehr
Copy link
Contributor

tduehr commented Jan 17, 2014

add buffer_spec for FFI and fix FFI::Buffer so the tests pass.

tduehr added some commits Jan 17, 2014

add MRI ffi specs
last failing currently
this *should* work
but... doesn't
@headius

This comment has been minimized.

After uncommenting these lines, I was able to run buffer_spec.rb to completion.

This comment has been minimized.

Copy link
Owner Author

tduehr replied Jan 17, 2014

maybe I was somehow picking up my jruby-1.7.10 install then.

@headius

This comment has been minimized.

Copy link
Member

headius commented Jan 17, 2014

Merged by hand to jruby-1_7 and I'll merge to master now.

@headius headius closed this Jan 17, 2014

@enebo enebo added this to the JRuby 1.7.11 milestone Feb 21, 2014

@tduehr tduehr deleted the tduehr:fix_ffi_buffer branch Mar 31, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.