Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore hex and random_bytes to SecureRandom 1.8 (fixes Travis) #1439

Merged
merged 1 commit into from Jan 27, 2014

Conversation

Projects
None yet
2 participants
@dmarcotte
Copy link
Contributor

dmarcotte commented Jan 24, 2014

The refactor which replaced hex and random_bytes with native code in SecureRandom accidentally left them broken for 1.8 (the commit which native-ed uuid moved the native extension loading behind a Ruby 1.9-only check). Restored!

This gets jruby-1_7 Travis green.

Restore hex and random_bytes to SecureRandom 1.8
The refactor which replaced hex and random_bytes with native code
in SecureRandom accidentally left them broken for 1.8.  Restored!
@dmarcotte

This comment has been minimized.

Copy link
Contributor Author

dmarcotte commented Jan 24, 2014

Heh. Of course Travis fails when I say "this gets it green". The failure here is due to network flakiness. Will be green on subsequent runs.

enebo added a commit that referenced this pull request Jan 27, 2014

Merge pull request #1439 from dmarcotte/securerand-18
Restore hex and random_bytes to SecureRandom 1.8 (fixes Travis)

@enebo enebo merged commit c273042 into jruby:jruby-1_7 Jan 27, 2014

1 check failed

default The Travis CI build failed
Details

@enebo enebo added this to the JRuby 1.7.11 milestone Feb 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.