Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better messaging with NameErrors #1506

Merged
merged 1 commit into from Feb 26, 2014

Conversation

Projects
None yet
3 participants
@jhspaybar
Copy link
Contributor

jhspaybar commented Feb 15, 2014

provide a pass through of the java error for easier debugging when jars actually exist but a name error manifests anyways

Makes something like this https://gist.github.com/adamstegman/5077010 far easier to debug. I also ran into on my own project attempting to load jars that had a JVM Security Policy violation.

This if my first pull request, so if I did something wrong, let me know.

I consent to having my contributions licensed under EPL, GPLv2, and LGPLv2.

provide a pass through of the java error for easier debugging when ja…
…rs actually exist but a name error manifests anyways
@ratnikov

This comment has been minimized.

Copy link

ratnikov commented on 30eb556 Feb 20, 2014

Sounds like you'd want that for better debugging. Perhaps do printStackTrace if runtime.getDebug() is true?

@headius

This comment has been minimized.

Copy link
Member

headius commented Feb 26, 2014

Seems good. Well probably audit these error messages for 9k to make them all consistently useful.

headius added a commit that referenced this pull request Feb 26, 2014

@headius headius merged commit f19bc66 into jruby:jruby-1_7 Feb 26, 2014

1 check failed

default The Travis CI build could not complete due to an error
Details

@headius headius added this to the JRuby 1.7.12 milestone Feb 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.