Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String#{to_r,to_c} should not use backref when calling gsub internally #1564

merged 1 commit into from Mar 17, 2014


Copy link

@atambo atambo commented Mar 16, 2014

Fixes #1563

Copy link
Member Author

@atambo atambo commented Mar 16, 2014

@headius, this commit just finishes up what you started in commit d00e21d. I think you just missed these two gsub calls but did all of the other match_m19 calls.

@atambo atambo added this to the JRuby 1.7.12 milestone Mar 16, 2014
enebo added a commit that referenced this pull request Mar 17, 2014

String#{to_r,to_c} should not use backref when calling gsub internally
@enebo enebo merged commit 43a1bae into jruby-1_7 Mar 17, 2014
1 check passed
1 check passed
default The Travis CI build passed
@nirvdrum nirvdrum deleted the dont_use_backref_for_string_to_r_and_to_c branch Apr 28, 2015
eregon added a commit that referenced this pull request Jun 29, 2017
86090df Add missing LF
abf1700 Use more standard String quotes
136a6fc Fix usage of old matchers/helpers
6252fe5 Remove unneeded specs.
a0a28cc When stop is nil or omitted to Numeric#step, it should be set to infinity_value, and sign would be same with step.
09f29cd Fixed Hash#{inspect, to_s}.
3990075 Fixed Array#{inspect, to_s}.
cb1a2a1 Kernel: allow caller{,_locations} to accept a Range
3b4c15b Add a spec for Float#% with coercion
df5d0c26 Use the argf helper in the ARGF.binmode spec
6795636 We can use the argf helper in ARGF.set_encoding spec instead of subprocesses
9d04f3a Add the possibility to use another ruby for the Process.{spawn,kill,wait} specs
77c9af7 Group related Process.kill specs together
5ab94c4 Do not send a signal while waiting in Process#kill specs
7d16235 Simply use echo to print text and environment variables in Process.spawn specs
95163fb Add spec for Fixnum#& with an Object responding to #coerce
2678e58 Add spec for Kernel#singleton_method
f9de23c Add a spec for dumping a Range with extra ivars
4883bc0 Add specs that classes of immediates undefine Class#new and have no allocator
0a10e20 Add some specs for Enumerator#inspect
fc79a3d Added version guards [Bug#12684]
9819db6 Delegate to `eql?` [Fix GH-1564]
b6bb571 Use a file under tmp for File.real{,dir}path specs on Windows
6ac2679 Adapt Time#zone spec to deal with differences of TZ validation on Windows
e9d8272 capi/spec_helper.rb: suppress logo
08cbf1d capi/spec_helper.rb: pass jobserver fds
93e73a3 capi/spec_helper.rb: use MAKE env
891bd72 Clear `DESTDIR` when running make
f1ac005 Use IO.popen over hacks with ruby_cmd + ruby_exe
f0ef6ea Use *ruby_exe instead of *ruby_cmd(nil).split in IO#popen spec
4f5bf9a Use *ruby_exe instead of ruby_cmd when we rely on the pid being ruby's pid
cbf6c15 Fix spacing of `do` keyword
3426b8a Manually stub __id__ in BasicObject#equal? spec
e3fac6e Make explicit that autoload is performed on Object

git-subtree-dir: spec/ruby
git-subtree-split: 86090df99c432f4ecd433c6e33373065113f96b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants