Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify documentation for isTrue, isFalse #1574

Merged
merged 2 commits into from Apr 1, 2014
Merged

Conversation

nilbus
Copy link
Contributor

@nilbus nilbus commented Mar 22, 2014

BasicRubyObject.isTrue and .isFalse correspond to whether the RubyObject is truthy or falsy, not just whether or not it is an instance of TrueClass or FalseClass. This documentation change makes that clear.

I confirmed this by calling isTrue on a RubyString, which returned true.

`BasicRubyObject.isTrue` and `.isFalse` correspond to whether the RubyObject is
truthy or falsy, not just whether or not it is an instance of TrueClass or
FalseClass. This documentation change makes that clear.

I confirmed this by calling `isTrue` on a RubyString, which returned true.
Metric: rspec, google search result count for: `ruby "falsey"` and `ruby "falsy"`
enebo added a commit that referenced this pull request Apr 1, 2014
Clarify documentation for isTrue, isFalse
@enebo enebo merged commit 1c357ce into jruby:master Apr 1, 2014
@enebo enebo added this to the JRuby 9000 milestone Apr 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants