Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor channeldescriptor to use FileResource #1587

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
2 participants
@ratnikov
Copy link
Contributor

ratnikov commented Mar 27, 2014

This is part of the #1452 effort.

This PR is a bit more invasive, since it introduces the concept of RaisableException and removes some of the more specific exceptions in org.jruby.util.io package.

In future, ChannelDescriptor.open method can probably be abolished altogether by introducing a NullResource (which will cover /dev/nul, nul:) and ClassPathResource (which at its first iteration would support just opening a descriptor, but eventually should be able to also support list[] and other File related methods).

@enebo

This comment has been minimized.

Copy link
Member

enebo commented Apr 1, 2014

Talked to @ratnikov about making this slightly more backwards compat for 1.7 branch and is just closing because I keep clicking on this thinking it has been updated...just re-open or submit a new one when it is ready.

@enebo enebo closed this Apr 1, 2014

@enebo enebo added this to the JRuby 1.7.12 milestone Apr 15, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.