Refactor channeldescriptor to use FileResource #1587

Closed
wants to merge 3 commits into
from

Projects

None yet

2 participants

@ratnikov
Contributor

This is part of the #1452 effort.

This PR is a bit more invasive, since it introduces the concept of RaisableException and removes some of the more specific exceptions in org.jruby.util.io package.

In future, ChannelDescriptor.open method can probably be abolished altogether by introducing a NullResource (which will cover /dev/nul, nul:) and ClassPathResource (which at its first iteration would support just opening a descriptor, but eventually should be able to also support list[] and other File related methods).

@enebo
Member
enebo commented Apr 1, 2014

Talked to @ratnikov about making this slightly more backwards compat for 1.7 branch and is just closing because I keep clicking on this thinking it has been updated...just re-open or submit a new one when it is ready.

@enebo enebo closed this Apr 1, 2014
@enebo enebo added this to the JRuby 1.7.12 milestone Apr 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment