Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compare_to for to_java'ed Ruby objects #1626

Merged
merged 1 commit into from Apr 14, 2014

Conversation

Projects
None yet
2 participants
@dmarcotte
Copy link
Contributor

dmarcotte commented Apr 12, 2014

Flip incorrect nil check which was resulting in #compare_to always returning 0 for many to_java'ed Ruby objects (anything not internally represented by a class which overrides RubyBasicObject#compareTo)

Fixes #1520

Fix compare_to for to_java'ed Ruby objects
Flip incorrect nil check which was resulting in #compare_to always
returning 0 for many to_java'ed Ruby objects (anything not internally
represented by a class which overrides RubyBasicObject#compareTo)

enebo added a commit that referenced this pull request Apr 14, 2014

Merge pull request #1626 from dmarcotte/test-compare-to
Fix compare_to for to_java'ed Ruby objects

@enebo enebo merged commit 93c81b3 into jruby:jruby-1_7 Apr 14, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details

@enebo enebo added this to the JRuby 1.7.12 milestone Apr 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.