Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not rescue java.lang.Error using StandardError #1697

Merged

Conversation

Projects
None yet
3 participants
@grddev
Copy link
Contributor

grddev commented May 14, 2014

This in effect injects java.lang.Error as a subclass of Ruby Exception, instead of StandardError as was previously the case.

This fixes #1696

Do not rescue java.lang.Error using StandardError
This in effect injects java.lang.Error as a subclass of Ruby Exception,
instead of StandardError as was previously the case.

This fixes #1696
@kares

This comment has been minimized.

Copy link
Member

kares commented May 16, 2014

Very najs Gustav, thank you!

enebo added a commit that referenced this pull request May 21, 2014

Merge pull request #1697 from grddev/rescue_java_errors_only_with_exc…
…eption

Do not rescue java.lang.Error using StandardError

@enebo enebo merged commit 47aebf9 into jruby:jruby-1_7 May 21, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build could not complete due to an error
Details

@enebo enebo added this to the JRuby 1.7.13 milestone May 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.