Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Treat SSL NOT_HANDSHAKING as FINISHED. #1707

Closed
wants to merge 4 commits into from

Conversation

Projects
None yet
3 participants
@donv
Copy link
Member

donv commented May 20, 2014

The code comment states that NOT_HANDSHAKING should be treated as FINISHED, but fails to reset the initialHandshake flag.

On Android, client connections complete OK in the NOT_HANDSHAKING state. This may be a bug on Android, but it has not changed since Android 2.3, and current source suggests it will stay that way ( https://android.googlesource.com/platform/libcore/+/master/luni/src/test/java/libcore/javax/net/ssl/SSLEngineTest.java )

The fix is to treat NOT_HANDSHAKING as FINISHED as per code comment. Tests run fine on OS X and travis as far as I can see.

@donv donv referenced this pull request May 20, 2014

Closed

Add support for SSL #154

@donv

This comment has been minimized.

Copy link
Member Author

donv commented May 20, 2014

The travis failure is the same as for master.

chrisseaton and others added some commits May 20, 2014

@donv

This comment has been minimized.

Copy link
Member Author

donv commented May 21, 2014

Committed the change.

@donv donv closed this May 21, 2014

@donv

This comment has been minimized.

Copy link
Member Author

donv commented on a080791 May 21, 2014

The code comment stated that NOT_HANDSHAKING should be treated as FINISHED, but fails to reset the initialHandshake flag.

On Android, client connections complete OK in the NOT_HANDSHAKING state. This may be a bug on Android, but it has not changed since Android 2.3, and current source suggests it will stay that way ( https://android.googlesource.com/platform/libcore/+/master/luni/src/test/java/libcore/javax/net/ssl/SSLEngineTest.java )

The fix is to treat NOT_HANDSHAKING as FINISHED as per code comment. Tests run fine on OS X and travis as far as I can see.

@enebo enebo added this to the JRuby 1.7.13 milestone Jun 24, 2014

@donv donv deleted the ssl_treat_not_handshaking_as_finished branch Apr 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.