Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor bug in `setNativeEnabled`, and expose it in ScriptingContainer #1803

Merged
merged 2 commits into from Jul 16, 2014

Conversation

Projects
None yet
3 participants
@cprice404
Copy link
Contributor

cprice404 commented Jul 9, 2014

This PR contains two commits. The first simply fixes a minor bug in the implementation of setNativeEnabled, where the parameter was being ignored and the value was always being set to false.

The second commit adds accessor methods for nativeEnabled to the ScriptingContainer class.

Chris Price added some commits Jul 9, 2014

Chris Price
Fix minor bug in setNativeEnabled
The implementation of setNativeEnabled previously had a hard-coded
value of `false`, and ignored the actual value that the caller
passed in.
@mkristian

This comment has been minimized.

Copy link

mkristian commented on 7c2fcc2 Jul 10, 2014

:)

@enebo enebo added this to the JRuby 1.7.14 milestone Jul 16, 2014

enebo added a commit that referenced this pull request Jul 16, 2014

Merge pull request #1803 from cprice404/fix-set-native-enabled
Fix minor bug in `setNativeEnabled`, and expose it in ScriptingContainer

@enebo enebo merged commit d654df7 into jruby:jruby-1_7 Jul 16, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build could not complete due to an error
Details

@enebo enebo modified the milestones: JRuby 1.7.14, JRuby 1.7.15 Aug 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.