Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply minor enebo's comments #1809

Merged
merged 1 commit into from Jul 16, 2014

Conversation

Projects
None yet
2 participants
@ratnikov
Copy link
Contributor

ratnikov commented Jul 13, 2014

Changes:

  1. Use new File(...).isAbsolute to detect whether path is absolute, rather than using a custom [probably faulty] regex.
  2. Kill unnecessary if on null.

Concerning returning buffered stream to optimize file loads. I have looked into it, but behavior on my SSD seems pretty identical, whether to wrap BuffereInputStream with 8096 buffer or not. To test I've added a system properties to switch between the two strategies and used rails 4 and following command:

bin/jruby -e 'require "benchmark"; puts Benchmark.measure { require "rails/all" }'

Whether I turn buffering or not, the result is usually around 25seconds CPU time (sometimes bumping up to 34 for either case). But maybe that's because seek time is not a factor for SSDs, so I will try it on a regular hard drive on Monday.

@enebo enebo added this to the JRuby 1.7.14 milestone Jul 16, 2014

enebo added a commit that referenced this pull request Jul 16, 2014

@enebo enebo merged commit cff0f68 into jruby:master Jul 16, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details

@enebo enebo modified the milestones: JRuby 1.7.14, JRuby 1.7.15 Aug 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.