Skip to content

Fix 6510 #183

Closed
wants to merge 3 commits into from

2 participants

@ryenus
ryenus commented May 26, 2012

This is to fix issue JRUBY-6510

In the past, when there's only 1 argument to String#encode!, the argument was always treated as the target encoding to transcode to.

This is wrong, because, when the only argument is a hash, it should be treated as the option for transcode, not the target encoding.

@headius
JRuby Team member
headius commented Aug 7, 2012

This one got lost in the shuffle. Can you re-push a version that applies to master and collapse your commits into one?

@ryenus
ryenus commented Aug 8, 2012

sure, I'll close this one and make a new PR

@ryenus ryenus closed this Aug 8, 2012
@ryenus
ryenus commented Oct 22, 2012

Just to make the story complete, the patch is resubmitted with pull request #255: #255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.