Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the memory leak and actually close the resources. #1898

Merged
merged 1 commit into from Aug 13, 2014

Conversation

@ratnikov
Copy link
Contributor

@ratnikov ratnikov commented Aug 13, 2014

This should fix #1888

I've opted for direct rename of getInputStream => openInputStream which technically can break people depending on it in 1.7.13 but in reality I doubt anyone started using that interface.

But I guess I can add a deprecated getInputStream back.

enebo added a commit that referenced this pull request Aug 13, 2014
Fix the memory leak and actually close the resources.
@enebo enebo merged commit 8cdea34 into jruby:jruby-1_7 Aug 13, 2014
1 check failed
1 check failed
@enebo
continuous-integration/travis-ci The Travis CI build failed
Details
@enebo enebo added this to the JRuby 1.7.14 milestone Aug 13, 2014
@enebo enebo modified the milestones: JRuby 1.7.14, JRuby 1.7.15 Aug 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants