Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak include order #2002

Merged
merged 1 commit into from Nov 2, 2014

Conversation

Projects
None yet
3 participants
@tduehr
Copy link
Contributor

commented Sep 25, 2014

resolves #1938

MRI doesn't set superclassseen if the next class up is an included module.

https://github.com/ruby/ruby/blob/trunk/class.c#L868

@tduehr tduehr force-pushed the tduehr:include_order branch from a24bb65 to 99da805 Sep 25, 2014

@enebo enebo added this to the JRuby 1.7.17 milestone Sep 25, 2014

@enebo

This comment has been minimized.

Copy link
Member

commented Sep 25, 2014

We can merge this for 1.7.17 but 1.7.16 is imminent so we will hold off.

@headius headius self-assigned this Nov 2, 2014

@headius headius added the core label Nov 2, 2014

headius added a commit that referenced this pull request Nov 2, 2014

@headius headius merged commit 0cb3433 into jruby:jruby-1_7 Nov 2, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build could not complete due to an error
Details

@tduehr tduehr deleted the tduehr:include_order branch Nov 14, 2014

MSNexploder added a commit to MSNexploder/jruby that referenced this pull request Jun 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.