Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented multi args 'system' method on Windows fix #1074 #2008

Merged
merged 1 commit into from Nov 2, 2014

Conversation

@yousuketto
Copy link
Contributor

@yousuketto yousuketto commented Sep 27, 2014

'system' method of multi args was not able to support Windows internal commands.
(ex) echo, cd, etc
fix #1074

jruby 1.7.16

# example.rb
p system("echo", "hoge")
p "----------"
p system("jruby", "-v")
c:\workspace\jruby1074>jruby example.rb
nil
"----------"
jruby 1.7.16 (1.9.3p392) 2014-09-25 575b395 on Java HotSpot(TM) 64-Bit Server VM 1.7.0_07-b11 +jit [Windows 7-amd64]
true
'system' method of multi args was not able to support
Windows internal commands.
(ex) echo, cd, etc
@headius
Copy link
Member

@headius headius commented Nov 2, 2014

Tests look ok and the change seems right. Can you help us a bit more by adding a regression spec to spec/regression? I will merge this.

headius added a commit that referenced this pull request Nov 2, 2014
Implemented multi args 'system' method on Windows fix #1074
@headius headius merged commit 581957e into jruby:jruby-1_7 Nov 2, 2014
1 check failed
1 check failed
@enebo
continuous-integration/travis-ci The Travis CI build failed
Details
@headius headius added this to the JRuby 1.7.17 milestone Nov 2, 2014
@headius headius self-assigned this Nov 2, 2014
yousuketto added a commit to yousuketto/jruby that referenced this pull request Nov 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants