Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 1695 : BigDecimal and Rational multiplication #2011

Conversation

@k77ch7
Copy link
Contributor

@k77ch7 k77ch7 commented Sep 29, 2014

This commit fixes issue #1695.

When converting to Ruby BigDecimal from Ruby Rational,
Java BigDecimal divide method runs by specifying the precision of the multiple of 4.

@k77ch7 k77ch7 changed the title fixed issue 1695 Fix for issue 1695 : BigDecimal and Rational multiplication Oct 24, 2014
@headius
Copy link
Member

@headius headius commented Nov 2, 2014

Very nice!

headius added a commit that referenced this issue Nov 2, 2014
…_multiplication

Fix for issue 1695 : BigDecimal and Rational multiplication
@headius headius merged commit 8a4ffea into jruby:jruby-1_7 Nov 2, 2014
1 check failed
@headius headius added this to the JRuby 1.7.17 milestone Nov 2, 2014
@headius headius added the core label Nov 2, 2014
@headius headius self-assigned this Nov 2, 2014
@k77ch7
Copy link
Contributor Author

@k77ch7 k77ch7 commented Nov 4, 2014

@headius Could you merge this PR into master branch?

@k77ch7 k77ch7 mentioned this pull request Dec 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants