Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 1695 : BigDecimal and Rational multiplication #2011

Conversation

Projects
None yet
2 participants
@k77ch7
Copy link
Contributor

k77ch7 commented Sep 29, 2014

This commit fixes issue #1695.

When converting to Ruby BigDecimal from Ruby Rational,
Java BigDecimal divide method runs by specifying the precision of the multiple of 4.

@k77ch7 k77ch7 changed the title fixed issue 1695 Fix for issue 1695 : BigDecimal and Rational multiplication Oct 24, 2014

@headius

This comment has been minimized.

Copy link
Member

headius commented Nov 2, 2014

Very nice!

headius added a commit that referenced this pull request Nov 2, 2014

Merge pull request #2011 from k77ch7/GH-1695_big_decimal_and_rational…
…_multiplication

Fix for issue 1695 : BigDecimal and Rational multiplication

@headius headius merged commit 8a4ffea into jruby:jruby-1_7 Nov 2, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build could not complete due to an error
Details

@headius headius added this to the JRuby 1.7.17 milestone Nov 2, 2014

@headius headius added the core label Nov 2, 2014

@headius headius self-assigned this Nov 2, 2014

@k77ch7

This comment has been minimized.

Copy link
Contributor Author

k77ch7 commented Nov 4, 2014

@headius Could you merge this PR into master branch?

@k77ch7 k77ch7 referenced this pull request Dec 11, 2014

Merged

Fix GH-1695 on master #2306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.