-
-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redefine uri:classloader: meaning #2027
Conversation
@mkristian great ... however unless there's real demand from users I'm sorry to just leave it as is for now |
@kares I missed to mention websphere and its packed.war where there are quite some open issues around with warbler (and maybe jruby itself). well, jruby works with those containers. but I see the list is indeed quite long - I will help on the maven/jbundler bits ! |
e80967a
to
753d31f
Compare
this fixes some flaws in the IsolatedScriptingContainer and is the prerequisite to merge this will work with regular embedded gems not more tricking with rubygems (see comment: #2055) as well it does not need to set the right classloader to ScriptingContainer anymore since the IsolatedScriptingContainer is able to determine the classloader which contains jruby-kernel - basically mimicking #2023 inside the IsolatedScriptingContainer. I can not provide a test case for problems in nexus-oss since the same osgi framework works using pax-testing. |
9d71d19
to
7d857a7
Compare
8341e05
to
abd65a4
Compare
e0315ea
to
ee8966d
Compare
…time.getJRubyClassLoader this allows to set JRubyHome to uri:classloader:/META-INF/jruby.home for all situations where there is a jruby.home packed inside a jar. fixes problem with loadService and knoplerfish OSGi fixed missed test and cleanup javadocs and add more junit-tests for uri:classloader: make IsolatedScriptingContainer work on felix-4.2.1 and probably on other osgi frameworks outside the pax test cases
… the context-classloader
ee8966d
to
99ff77d
Compare
I pushed with '--force' so often that the diffs here do not match the actual commits. close this and make a new. |
redefine uri:classloader: meaning to be the parent classloader of runtime.getJRubyClassLoader
this allows to set JRubyHome to uri:classloader:/META-INF/jruby.home for all situations where there is a jruby.home packed inside a jar.
fixes problem with loadService and knoplerfish OSGi and activated the tests for knoplerfish
@enebo @ratnikov I made this against the jruby-1_7 and hope this OK since it is only used by IsolatedScriptingContainer and has no effect on the rest of JRuby.
@kares if jruby-rack would accommodate the IsolatedScriptingContainer via some config or so, then this could finally fix websphere or jboss-wildfly packed with warbler (not sure what surprises bundler has).