Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redefine uri:classloader: meaning #2027

Closed
wants to merge 2 commits into from

Conversation

mkristian
Copy link
Member

@mkristian mkristian commented Oct 7, 2014

redefine uri:classloader: meaning to be the parent classloader of runtime.getJRubyClassLoader

this allows to set JRubyHome to uri:classloader:/META-INF/jruby.home for all situations where there is a jruby.home packed inside a jar.

fixes problem with loadService and knoplerfish OSGi and activated the tests for knoplerfish

@enebo @ratnikov I made this against the jruby-1_7 and hope this OK since it is only used by IsolatedScriptingContainer and has no effect on the rest of JRuby.
@kares if jruby-rack would accommodate the IsolatedScriptingContainer via some config or so, then this could finally fix websphere or jboss-wildfly packed with warbler (not sure what surprises bundler has).

@kares
Copy link
Member

@kares kares commented Oct 7, 2014

@mkristian great ... however unless there's real demand from users I'm sorry to just leave it as is for now
feel free to open a linked issue on JRuby-Rack and tell us about the non-exploded .war case this could solve ... and if people come along commenting we shall definitely consider putting it in - for now the schedule is pretty packed jruby/jruby-rack#168 I'm not sure if or when I'll actually get to it actually ;(

@mkristian
Copy link
Member Author

@mkristian mkristian commented Oct 7, 2014

@kares I missed to mention websphere and its packed.war where there are quite some open issues around with warbler (and maybe jruby itself). well, jruby works with those containers. but I see the list is indeed quite long - I will help on the maven/jbundler bits !

@mkristian
Copy link
Member Author

@mkristian mkristian commented Oct 19, 2014

this fixes some flaws in the IsolatedScriptingContainer and is the prerequisite to merge
sonatype/nexus-oss#802

this will work with regular embedded gems not more tricking with rubygems (see comment: #2055) as well it does not need to set the right classloader to ScriptingContainer anymore since the IsolatedScriptingContainer is able to determine the classloader which contains jruby-kernel - basically mimicking #2023 inside the IsolatedScriptingContainer.

I can not provide a test case for problems in nexus-oss since the same osgi framework works using pax-testing.

@mkristian mkristian force-pushed the redefine-uri-classloader-meaning branch 2 times, most recently from 9d71d19 to 7d857a7 Compare Oct 20, 2014
@mkristian mkristian force-pushed the redefine-uri-classloader-meaning branch 2 times, most recently from 8341e05 to abd65a4 Compare Nov 5, 2014
@mkristian mkristian force-pushed the redefine-uri-classloader-meaning branch 2 times, most recently from e0315ea to ee8966d Compare Nov 14, 2014
mkristian added 2 commits Dec 3, 2014
…time.getJRubyClassLoader

this allows to set JRubyHome to uri:classloader:/META-INF/jruby.home for all situations where
there is a jruby.home packed inside a jar.

fixes problem with loadService and knoplerfish OSGi

fixed missed test and cleanup javadocs and add more junit-tests for uri:classloader:

make IsolatedScriptingContainer work on felix-4.2.1 and probably on other osgi frameworks outside the pax test cases
@mkristian mkristian force-pushed the redefine-uri-classloader-meaning branch from ee8966d to 99ff77d Compare Dec 3, 2014
@mkristian
Copy link
Member Author

@mkristian mkristian commented Dec 5, 2014

I pushed with '--force' so often that the diffs here do not match the actual commits. close this and make a new.

@mkristian mkristian closed this Dec 5, 2014
@mkristian mkristian deleted the redefine-uri-classloader-meaning branch Dec 5, 2014
@mkristian mkristian restored the redefine-uri-classloader-meaning branch Dec 5, 2014
@headius headius added this to the Invalid or Duplicate milestone May 4, 2015
@headius headius added this to the Invalid or Duplicate milestone May 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants