Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demonstrate pedantic option #2036

Merged
merged 7 commits into from Oct 16, 2014

Conversation

Projects
None yet
1 participant
@chrisseaton
Copy link
Contributor

chrisseaton commented Oct 10, 2014

This is what I am talking about for #2020.

I've added an option -Xcompliance.strict. When this option is enabled I've slightly changed argument processing so it matches what RubySpec thinks it should be, as a simple example to get started with. Specifically, we don't process arguments like --help in RUBYOPT, and we add a new --yydebug option (just our --dump yydebug by a different name).

I then run my Truffle specs with this option enabled. This gets Truffle to pass 18 more expectations, or around 0.6% of the RubySpec total for language. Every little helps!

Maybe there are more failing language specs in JRuby where this would allow us to show we pass the specs, but still keep our preferred behaviour.

chrisseaton added a commit that referenced this pull request Oct 16, 2014

Merge pull request #2036 from jruby/pedantic
Start of minimal strict compliance mode.

@chrisseaton chrisseaton merged commit 3388591 into master Oct 16, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details

@chrisseaton chrisseaton deleted the pedantic branch Oct 16, 2014

@chrisseaton chrisseaton modified the milestone: JRuby 9.0.0.0.rc1 May 4, 2015

kares added a commit that referenced this pull request Feb 8, 2018

align C ported memsearch code - need to handle array[length] properly
... otherwise code doing utf8 str scan might fail with array-out-of-index

resolves GH-2036
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.