Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix JsonProfilePrinter #2187
Also remove some calls to rspec's
@headius, with this the spec/profiler specs are green for 1.7. Do you want to re-enable on Travis?
referenced this pull request
Nov 12, 2014
Ready to go! Specs are enabled and verified (also fixed a problem where it was messing with rake's final outcome in spite of all passing tests).
Note: I only flipped the switch for 1.9 since it turns out there's still one failure for 1.8:
Let me know if there's a strong desire to see 1.8 profile specs running in Travis and I'll try and send a follow-up pull addressing this.
2 times, most recently
Aug 10, 2015
@headius just noticed this guy was unmerged... just slipped off your radar too? (No worries if that's the case!) Or is there something we want to address here?
Also: I just rebased to the latest