Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 1069 and 1390 on master: improve handling of non ascii character after backslash #2210

Conversation

Projects
None yet
2 participants
@k77ch7
Copy link
Contributor

commented Nov 17, 2014

I create this pull request #2210, since the pull request #2064 for 1_7 branch can not be merged into master branch. This pull request improves handling of non ascii character after backslash of org.jruby.lexer.yacc.StringTerm class on master. This change fixes #1069 and #1390.

@k77ch7 k77ch7 changed the title improve handling of non ascii character after backslash on master Fix for issue 1069 and 1390 on master: improve handling of non ascii character after backslash Jan 22, 2015

@k77ch7 k77ch7 force-pushed the k77ch7:improve_handling_of_nonascii_character_after_backslash_on_master branch from 526b0fd to e05156d Jan 22, 2015

@k77ch7

This comment has been minimized.

Copy link
Contributor Author

commented Jan 22, 2015

Rebased on the current master.

@k77ch7 k77ch7 force-pushed the k77ch7:improve_handling_of_nonascii_character_after_backslash_on_master branch from e05156d to 1c1838e Feb 12, 2015

@k77ch7

This comment has been minimized.

Copy link
Contributor Author

commented Feb 12, 2015

@enebo #1069 and #1390 work on jruby-1.7.19 but these broken still on master. Please review this PR and merge it into master. Thank you.

enebo added a commit that referenced this pull request Feb 13, 2015

Merge pull request #2210 from k77ch7/improve_handling_of_nonascii_cha…
…racter_after_backslash_on_master

Fix for issue 1069 and 1390 on master: improve handling of non ascii character after backslash

@enebo enebo merged commit df6c028 into jruby:master Feb 13, 2015

1 check failed

continuous-integration/travis-ci The Travis CI build could not complete due to an error
Details

@enebo enebo added the JRuby 9000 label Feb 13, 2015

@enebo enebo added this to the 9.0.0.0.pre2 milestone Feb 13, 2015

@enebo enebo added the parser label Feb 13, 2015

@k77ch7

This comment has been minimized.

Copy link
Contributor Author

commented Feb 14, 2015

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.