Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versions #2211

Merged
merged 4 commits into from Nov 18, 2014
Merged

Versions #2211

merged 4 commits into from Nov 18, 2014

Conversation

mkristian
Copy link
Member

@mkristian mkristian commented Nov 17, 2014

this is meant to resolve the issue #2206

all artifacts follow the version in the file VERSION beside the jruby-jars gems where '-SNAPSHOT' gets converted to '.snapshot'

@chrisseaton
Copy link
Contributor

chrisseaton commented Nov 17, 2014

That much cleaner - thanks very much for taking the time to do that. I think the .snapshot for the gems looks fine.

@mkristian
Copy link
Member Author

mkristian commented Nov 18, 2014

just saw that jruby/jruby-rack uses ".SNAPSHOT" for their gems: https://github.com/jruby/jruby-rack/blob/1.1-stable/Rakefile#L131

maybe to keep things even consistent over the various jruby projects ?

@chrisseaton
Copy link
Contributor

chrisseaton commented Nov 18, 2014

Which are you proposing we change? jruby or jruby-rack? I'm not sure if .snapshot or .SNAPSHOT looks more conventional for a gem so don't have an opinion.

@mkristian
Copy link
Member Author

mkristian commented Nov 18, 2014

to change jruby-rack means we need to take the discussion to jruby-rack and
they use the .SNAPSHOT already for a while. no - I was proposing to use
.SNAPSHOT for jruby-jars gem - but it is not really important ;)

please feel free to merge the PR any time when need

chrisseaton added a commit that referenced this issue Nov 18, 2014
@chrisseaton chrisseaton merged commit 43a9fd4 into master Nov 18, 2014
@chrisseaton chrisseaton deleted the versions branch Nov 18, 2014
@headius headius modified the milestone: Invalid or Duplicate May 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants