Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparable#== raises SystemStackError when calling classes don't impleme... #2233

Closed

Conversation

mjgpy3
Copy link

@mjgpy3 mjgpy3 commented Nov 24, 2014

...nt #<=>

Using recursive pattern

@headius
Copy link
Member

@headius headius commented Nov 24, 2014

Looks good, but you might as well remove the catch of StackOverflowError now. No need to make a new pull request, just make the change and push again :-)

@mjgpy3
Copy link
Author

@mjgpy3 mjgpy3 commented Nov 24, 2014

@headius, interesting, thanks so much for the feedback. What code raises the ruby-land SSE then?

@mjgpy3
Copy link
Author

@mjgpy3 mjgpy3 commented Nov 24, 2014

Also, there have been some failing tests. Are these expected?

@headius
Copy link
Member

@headius headius commented Jan 12, 2015

Finally circling back to PRs...

Test should be generally green on master now. This were in flux during November and December.

The patch is ok, but it doesn't pay attention to the recursion guard's "recur" argument (the boolean you have named ___). recur == true should trigger the inspect output to insert special text indicating a recursion.

@MSNexploder
Copy link
Contributor

@MSNexploder MSNexploder commented Jun 4, 2015

#3006 fixed that

@kares
Copy link
Member

@kares kares commented Aug 5, 2015

closing since #3006 has been merged

@kares kares closed this Aug 5, 2015
@enebo enebo modified the milestone: Non-Release May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants