Make loading service extensions work with classloader path #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkristian
added a commit
that referenced
this pull request
Dec 6, 2014
Make loading service extensions work with classloader path
|
the patch #2055 (comment) and #2278 is the replacement for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: #2055
Note that the logic added to JarredScript is almost identical to logic in LibrarySearcher when dealing with loading a jar file (https://github.com/jruby/jruby/blob/jruby-1_7/core/src/main/java/org/jruby/runtime/load/LibrarySearcher.java#L309)
It may make sense to see if the logic can be combined. On other hand, since mkristian is pretty close to killing findLibraryWithClassloaders in master, maybe the effort is not necessary.