Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make loading service extensions work with classloader path #2281

Merged
merged 1 commit into from Dec 6, 2014

Conversation

ratnikov
Copy link
Contributor

@ratnikov ratnikov commented Dec 5, 2014

Fixed: #2055

Note that the logic added to JarredScript is almost identical to logic in LibrarySearcher when dealing with loading a jar file (https://github.com/jruby/jruby/blob/jruby-1_7/core/src/main/java/org/jruby/runtime/load/LibrarySearcher.java#L309)

It may make sense to see if the logic can be combined. On other hand, since mkristian is pretty close to killing findLibraryWithClassloaders in master, maybe the effort is not necessary.

mkristian added a commit that referenced this issue Dec 6, 2014
Make loading service extensions work with classloader path
@mkristian mkristian merged commit 1ff2d5a into jruby:jruby-1_7 Dec 6, 2014
1 check passed
@mkristian
Copy link
Member

@mkristian mkristian commented Dec 6, 2014

the patch #2055 (comment) and #2278 is the replacement for findLibraryWithClassloaders :)

@headius headius added this to the Invalid or Duplicate milestone May 4, 2015
@headius headius added this to the Invalid or Duplicate milestone May 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants