Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes that address tests with current jruby-openssl master #2311

Closed
wants to merge 4 commits into from
Closed

changes that address tests with current jruby-openssl master #2311

wants to merge 4 commits into from

Conversation

kares
Copy link
Member

@kares kares commented Dec 12, 2014

this will need to go in eventually if the current jruby-openssl master is used for the next release.

these changes will NOT pass with 0.9.5 ... there's still 6 left (reported on openssl's repo), for the record :

  1) Error:
test_decode(OpenSSL::TestASN1):
OpenSSL::ASN1::ASN1Error: DER length more than 4 bytes: 126
    org/jruby/ext/openssl/ASN1.java:1098:in `decode'
    /home/kares/workspace/oss/jruby/test/externals/ruby1.9/openssl/test_asn1.rb:176:in `test_decode'

  2) Failure:
test_primitive_cannot_set_infinite_length(OpenSSL::TestASN1) [/home/kares/workspace/oss/jruby/test/externals/ruby1.9/openssl/test_asn1.rb:237]:
Could set infinite length on primitive value

  3) Failure:
test_revoked(OpenSSL::TestX509CRL) [/home/kares/workspace/oss/jruby/test/externals/ruby1.9/openssl/test_x509crl.rb:92]:
<"Key Compromise"> expected but was
<"Unspecified">.

  4) Error:
test_sign_and_verify(OpenSSL::TestX509CRL):
Java::JavaLang::ClassCastException: org.bouncycastle.asn1.ASN1Enumerated cannot be cast to org.bouncycastle.asn1.ASN1Sequence
    org.bouncycastle.crypto.signers.DSADigestSigner.derDecode(Unknown Source)
    org.bouncycastle.crypto.signers.DSADigestSigner.verifySignature(Unknown Source)
    org.bouncycastle.operator.bc.BcSignerOutputStream.verify(Unknown Source)
    org.bouncycastle.operator.bc.BcContentVerifierProviderBuilder$SigVerifier.verify(Unknown Source)
    org.bouncycastle.cert.X509CRLHolder.isSignatureValid(Unknown Source)
    org.jruby.ext.openssl.X509CRL.verify(X509CRL.java:766)
    org.jruby.ext.openssl.X509CRL$INVOKER$i$1$0$verify.call(X509CRL$INVOKER$i$1$0$verify.gen)
    org.jruby.runtime.callsite.CachingCallSite.cacheAndCall(CachingCallSite.java:326)
    org.jruby.runtime.callsite.CachingCallSite.call(CachingCallSite.java:170)
    org.jruby.ast.CallOneArgNode.interpret(CallOneArgNode.java:57)
    org.jruby.ast.NewlineNode.interpret(NewlineNode.java:105)
    org.jruby.evaluator.ASTInterpreter.INTERPRET_BLOCK(ASTInterpreter.java:112)
    org.jruby.runtime.Interpreted19Block.evalBlockBody(Interpreted19Block.java:206)
    org.jruby.runtime.Interpreted19Block.yield(Interpreted19Block.java:157)
    org.jruby.runtime.Interpreted19Block.yieldSpecific(Interpreted19Block.java:130)
    org.jruby.runtime.Block.yieldSpecific(Block.java:111)
    org.jruby.ast.ZYieldNode.interpret(ZYieldNode.java:25)
    org.jruby.ast.NewlineNode.interpret(NewlineNode.java:105)
    org.jruby.ast.RescueNode.executeBody(RescueNode.java:221)
    org.jruby.ast.RescueNode.interpret(RescueNode.java:116)
    org.jruby.evaluator.ASTInterpreter.INTERPRET_METHOD(ASTInterpreter.java:74)
    org.jruby.internal.runtime.methods.InterpretedMethod.call(InterpretedMethod.java:161)
    org.jruby.runtime.callsite.CachingCallSite.cacheAndCall(CachingCallSite.java:316)
    org.jruby.runtime.callsite.CachingCallSite.callBlock(CachingCallSite.java:145)
    org.jruby.runtime.callsite.CachingCallSite.callIter(CachingCallSite.java:154)
    org.jruby.ast.FCallNoArgBlockNode.interpret(FCallNoArgBlockNode.java:32)
    org.jruby.ast.FCallTwoArgNode.interpret(FCallTwoArgNode.java:38)
    org.jruby.ast.NewlineNode.interpret(NewlineNode.java:105)
    org.jruby.ast.BlockNode.interpret(BlockNode.java:71)
    org.jruby.evaluator.ASTInterpreter.INTERPRET_METHOD(ASTInterpreter.java:74)
    org.jruby.internal.runtime.methods.InterpretedMethod.call(InterpretedMethod.java:161)
    org.jruby.RubyClass.finvoke(RubyClass.java:528)
    org.jruby.RubyBasicObject.send19(RubyBasicObject.java:1501)
    org.jruby.RubyBasicObject$INVOKER$i$send19.call(RubyBasicObject$INVOKER$i$send19.gen)
    org.jruby.internal.runtime.methods.JavaMethod$JavaMethodOneOrNBlock.call(JavaMethod.java:350)
    org.jruby.internal.runtime.methods.AliasMethod.call(AliasMethod.java:61)
    org.jruby.runtime.callsite.CachingCallSite.call(CachingCallSite.java:168)
    org.jruby.ast.CallOneArgNode.interpret(CallOneArgNode.java:57)
    org.jruby.ast.NewlineNode.interpret(NewlineNode.java:105)
    org.jruby.ast.BlockNode.interpret(BlockNode.java:71)
    org.jruby.ast.RescueNode.executeBody(RescueNode.java:221)
    org.jruby.ast.RescueNode.interpret(RescueNode.java:116)
    org.jruby.ast.EnsureNode.interpret(EnsureNode.java:96)
    org.jruby.ast.BeginNode.interpret(BeginNode.java:83)
    org.jruby.ast.NewlineNode.interpret(NewlineNode.java:105)
    org.jruby.ast.BlockNode.interpret(BlockNode.java:71)
    org.jruby.evaluator.ASTInterpreter.INTERPRET_METHOD(ASTInterpreter.java:74)
    org.jruby.internal.runtime.methods.InterpretedMethod.call(InterpretedMethod.java:204)
    org.jruby.runtime.callsite.SuperCallSite.callBlock(SuperCallSite.java:190)
    org.jruby.runtime.callsite.SuperCallSite.call(SuperCallSite.java:197)
    org.jruby.runtime.callsite.SuperCallSite.callVarargs(SuperCallSite.java:108)
    org.jruby.ast.SuperNode.interpret(SuperNode.java:115)
    org.jruby.ast.NewlineNode.interpret(NewlineNode.java:105)
    org.jruby.ast.BlockNode.interpret(BlockNode.java:71)
    org.jruby.evaluator.ASTInterpreter.INTERPRET_METHOD(ASTInterpreter.java:74)
    org.jruby.internal.runtime.methods.InterpretedMethod.call(InterpretedMethod.java:182)
    org.jruby.runtime.callsite.CachingCallSite.call(CachingCallSite.java:168)
    org.jruby.ast.CallOneArgNode.interpret(CallOneArgNode.java:57)
    org.jruby.ast.DAsgnNode.interpret(DAsgnNode.java:110)
    org.jruby.ast.NewlineNode.interpret(NewlineNode.java:105)
    org.jruby.ast.BlockNode.interpret(BlockNode.java:71)
    org.jruby.evaluator.ASTInterpreter.INTERPRET_BLOCK(ASTInterpreter.java:112)
    org.jruby.runtime.Interpreted19Block.evalBlockBody(Interpreted19Block.java:206)
    org.jruby.runtime.Interpreted19Block.yield(Interpreted19Block.java:157)
    org.jruby.runtime.Block.yield(Block.java:142)
    org.jruby.RubyArray.collect(RubyArray.java:2399)
    org.jruby.RubyArray.map19(RubyArray.java:2412)
    org.jruby.RubyArray$INVOKER$i$0$0$map19.call(RubyArray$INVOKER$i$0$0$map19.gen)
    org.jruby.runtime.callsite.CachingCallSite.callBlock(CachingCallSite.java:143)
    org.jruby.runtime.callsite.CachingCallSite.callIter(CachingCallSite.java:154)
    org.jruby.ast.CallNoArgBlockNode.interpret(CallNoArgBlockNode.java:64)
    org.jruby.ast.LocalAsgnNode.interpret(LocalAsgnNode.java:123)
    org.jruby.ast.NewlineNode.interpret(NewlineNode.java:105)
    org.jruby.ast.BlockNode.interpret(BlockNode.java:71)
    org.jruby.evaluator.ASTInterpreter.INTERPRET_METHOD(ASTInterpreter.java:74)
    org.jruby.internal.runtime.methods.InterpretedMethod.call(InterpretedMethod.java:225)
    org.jruby.runtime.callsite.CachingCallSite.call(CachingCallSite.java:202)
    org.jruby.ast.FCallTwoArgNode.interpret(FCallTwoArgNode.java:38)
    org.jruby.ast.CallOneArgNode.interpret(CallOneArgNode.java:57)
    org.jruby.ast.NewlineNode.interpret(NewlineNode.java:105)
    org.jruby.ast.RescueNode.executeBody(RescueNode.java:221)
    org.jruby.ast.RescueNode.interpret(RescueNode.java:116)
    org.jruby.ast.BeginNode.interpret(BeginNode.java:83)
    org.jruby.ast.NewlineNode.interpret(NewlineNode.java:105)
    org.jruby.evaluator.ASTInterpreter.INTERPRET_BLOCK(ASTInterpreter.java:112)
    org.jruby.runtime.Interpreted19Block.evalBlockBody(Interpreted19Block.java:206)
    org.jruby.runtime.Interpreted19Block.yield(Interpreted19Block.java:157)
    org.jruby.runtime.Block.yield(Block.java:142)
    org.jruby.RubyArray.eachCommon(RubyArray.java:1606)
    org.jruby.RubyArray.each(RubyArray.java:1613)
    org.jruby.RubyArray$INVOKER$i$0$0$each.call(RubyArray$INVOKER$i$0$0$each.gen)
    org.jruby.runtime.callsite.CachingCallSite.cacheAndCall(CachingCallSite.java:316)
    org.jruby.runtime.callsite.CachingCallSite.callBlock(CachingCallSite.java:145)
    org.jruby.runtime.callsite.CachingCallSite.callIter(CachingCallSite.java:154)
    org.jruby.ast.CallNoArgBlockNode.interpret(CallNoArgBlockNode.java:64)
    org.jruby.ast.NewlineNode.interpret(NewlineNode.java:105)
    org.jruby.ast.IfNode.interpret(IfNode.java:118)
    org.jruby.ast.NewlineNode.interpret(NewlineNode.java:105)
    org.jruby.ast.BlockNode.interpret(BlockNode.java:71)
    org.jruby.evaluator.ASTInterpreter.INTERPRET_METHOD(ASTInterpreter.java:74)
    org.jruby.internal.runtime.methods.InterpretedMethod.call(InterpretedMethod.java:225)
    org.jruby.runtime.callsite.CachingCallSite.cacheAndCall(CachingCallSite.java:346)
    org.jruby.runtime.callsite.CachingCallSite.call(CachingCallSite.java:204)
    org.jruby.ast.FCallTwoArgNode.interpret(FCallTwoArgNode.java:38)
    org.jruby.ast.LocalAsgnNode.interpret(LocalAsgnNode.java:123)
    org.jruby.ast.NewlineNode.interpret(NewlineNode.java:105)
    org.jruby.ast.BlockNode.interpret(BlockNode.java:71)
    org.jruby.evaluator.ASTInterpreter.INTERPRET_METHOD(ASTInterpreter.java:74)
    org.jruby.internal.runtime.methods.InterpretedMethod.call(InterpretedMethod.java:182)
    org.jruby.runtime.callsite.CachingCallSite.cacheAndCall(CachingCallSite.java:326)
    org.jruby.runtime.callsite.CachingCallSite.call(CachingCallSite.java:170)
    org.jruby.ast.FCallOneArgNode.interpret(FCallOneArgNode.java:36)
    org.jruby.ast.NewlineNode.interpret(NewlineNode.java:105)
    org.jruby.evaluator.ASTInterpreter.INTERPRET_METHOD(ASTInterpreter.java:74)
    org.jruby.internal.runtime.methods.InterpretedMethod.call(InterpretedMethod.java:161)
    org.jruby.RubyClass.finvoke(RubyClass.java:528)
    org.jruby.RubyBasicObject.send19(RubyBasicObject.java:1501)
    org.jruby.RubyKernel.send19(RubyKernel.java:2235)
    org.jruby.RubyKernel$INVOKER$s$send19.call(RubyKernel$INVOKER$s$send19.gen)
    org.jruby.internal.runtime.methods.JavaMethod$JavaMethodOneOrNBlock.call(JavaMethod.java:350)
    org.jruby.runtime.callsite.CachingCallSite.cacheAndCall(CachingCallSite.java:326)
    org.jruby.runtime.callsite.CachingCallSite.call(CachingCallSite.java:170)
    org.jruby.ast.FCallOneArgNode.interpret(FCallOneArgNode.java:36)
    org.jruby.ast.NewlineNode.interpret(NewlineNode.java:105)
    org.jruby.ast.BlockNode.interpret(BlockNode.java:71)
    org.jruby.evaluator.ASTInterpreter.INTERPRET_BLOCK(ASTInterpreter.java:112)
    org.jruby.runtime.Interpreted19Block.evalBlockBody(Interpreted19Block.java:206)
    org.jruby.runtime.Interpreted19Block.yield(Interpreted19Block.java:157)
    org.jruby.runtime.Block.yield(Block.java:142)
    org.jruby.RubyArray.eachCommon(RubyArray.java:1606)
    org.jruby.RubyArray.each(RubyArray.java:1613)
    org.jruby.RubyArray$INVOKER$i$0$0$each.call(RubyArray$INVOKER$i$0$0$each.gen)
    org.jruby.runtime.callsite.CachingCallSite.cacheAndCall(CachingCallSite.java:316)
    org.jruby.runtime.callsite.CachingCallSite.callBlock(CachingCallSite.java:145)
    org.jruby.runtime.callsite.CachingCallSite.callIter(CachingCallSite.java:154)
    org.jruby.ast.CallNoArgBlockNode.interpret(CallNoArgBlockNode.java:64)
    org.jruby.ast.NewlineNode.interpret(NewlineNode.java:105)
    org.jruby.ast.BlockNode.interpret(BlockNode.java:71)
    org.jruby.ast.RescueNode.executeBody(RescueNode.java:221)
    org.jruby.ast.RescueNode.interpret(RescueNode.java:116)
    org.jruby.evaluator.ASTInterpreter.INTERPRET_METHOD(ASTInterpreter.java:74)
    org.jruby.internal.runtime.methods.InterpretedMethod.call(InterpretedMethod.java:182)
    org.jruby.runtime.callsite.CachingCallSite.cacheAndCall(CachingCallSite.java:326)
    org.jruby.runtime.callsite.CachingCallSite.call(CachingCallSite.java:170)
    org.jruby.ast.CallOneArgNode.interpret(CallOneArgNode.java:57)
    org.jruby.ast.NewlineNode.interpret(NewlineNode.java:105)
    org.jruby.evaluator.ASTInterpreter.INTERPRET_METHOD(ASTInterpreter.java:74)
    org.jruby.internal.runtime.methods.InterpretedMethod.call(InterpretedMethod.java:204)
    org.jruby.runtime.callsite.SuperCallSite.cacheAndCall(SuperCallSite.java:366)
    org.jruby.runtime.callsite.SuperCallSite.callBlock(SuperCallSite.java:192)
    org.jruby.runtime.callsite.SuperCallSite.call(SuperCallSite.java:197)
    org.jruby.runtime.callsite.SuperCallSite.callVarargs(SuperCallSite.java:108)
    org.jruby.ast.ZSuperNode.interpret(ZSuperNode.java:103)
    org.jruby.ast.NewlineNode.interpret(NewlineNode.java:105)
    org.jruby.ast.BlockNode.interpret(BlockNode.java:71)
    org.jruby.evaluator.ASTInterpreter.INTERPRET_METHOD(ASTInterpreter.java:74)
    org.jruby.internal.runtime.methods.InterpretedMethod.call(InterpretedMethod.java:182)
    org.jruby.runtime.callsite.CachingCallSite.cacheAndCall(CachingCallSite.java:326)
    org.jruby.runtime.callsite.CachingCallSite.call(CachingCallSite.java:170)
    org.jruby.ast.CallOneArgNode.interpret(CallOneArgNode.java:57)
    org.jruby.ast.OrNode.interpret(OrNode.java:97)
    org.jruby.ast.FCallOneArgNode.interpret(FCallOneArgNode.java:36)
    org.jruby.ast.NewlineNode.interpret(NewlineNode.java:105)
    org.jruby.evaluator.ASTInterpreter.INTERPRET_BLOCK(ASTInterpreter.java:112)
    org.jruby.runtime.Interpreted19Block.evalBlockBody(Interpreted19Block.java:206)
    org.jruby.runtime.Interpreted19Block.yield(Interpreted19Block.java:157)
    org.jruby.runtime.Interpreted19Block.yieldSpecific(Interpreted19Block.java:130)
    org.jruby.runtime.Block.yieldSpecific(Block.java:111)
    org.jruby.ast.ZYieldNode.interpret(ZYieldNode.java:25)
    org.jruby.ast.NewlineNode.interpret(NewlineNode.java:105)
    org.jruby.ast.BlockNode.interpret(BlockNode.java:71)
    org.jruby.evaluator.ASTInterpreter.INTERPRET_METHOD(ASTInterpreter.java:74)
    org.jruby.internal.runtime.methods.InterpretedMethod.call(InterpretedMethod.java:161)
    org.jruby.internal.runtime.methods.WrapperMethod.call(WrapperMethod.java:74)
    org.jruby.runtime.callsite.CachingCallSite.cacheAndCall(CachingCallSite.java:316)
    org.jruby.runtime.callsite.CachingCallSite.callBlock(CachingCallSite.java:145)
    org.jruby.runtime.callsite.CachingCallSite.callIter(CachingCallSite.java:154)
    org.jruby.ast.CallNoArgBlockNode.interpret(CallNoArgBlockNode.java:64)
    org.jruby.ast.IfNode.interpret(IfNode.java:118)
    org.jruby.ast.NewlineNode.interpret(NewlineNode.java:105)
    org.jruby.evaluator.ASTInterpreter.INTERPRET_BLOCK(ASTInterpreter.java:112)
    org.jruby.runtime.Interpreted19Block.evalBlockBody(Interpreted19Block.java:206)
    org.jruby.runtime.Interpreted19Block.yield(Interpreted19Block.java:194)
    org.jruby.runtime.Interpreted19Block.call(Interpreted19Block.java:125)
    org.jruby.runtime.Block.call(Block.java:101)
    org.jruby.RubyProc.call(RubyProc.java:290)
    org.jruby.RubyProc.call(RubyProc.java:228)
    org.jruby.Ruby.tearDown(Ruby.java:3160)
    org.jruby.Ruby.tearDown(Ruby.java:3144)
    org.jruby.Main.internalRun(Main.java:294)
    org.jruby.Main.run(Main.java:217)
    org.jruby.Main.main(Main.java:197)

  5) Error:
test_verify(OpenSSL::TestX509Store):
OpenSSL::X509::StoreError: java.security.NoSuchProviderException: no such provider: BC
    org/jruby/ext/openssl/X509StoreContext.java:152:in `verify'
    org/jruby/ext/openssl/X509Store.java:229:in `verify'
    /home/kares/workspace/oss/jruby/test/externals/ruby1.9/openssl/test_x509store.rb:159:in `test_verify'

  6) Failure:
test_to_pem_with_empty_object(TestCertificate) [org.jruby.ext.openssl.impl.PKCS10Request.toASN1Structure(PKCS10Request.java:172)]:
Exception raised:
<java.lang.IllegalStateException: request not signed>.

@kares kares mentioned this pull request Dec 12, 2014
Closed
@mkristian
Copy link
Member

@mkristian mkristian commented Dec 15, 2014

merge manually into test-jossl-0.9.6 branch

@mkristian mkristian closed this Dec 15, 2014
@headius headius added this to the JRuby 9.0.0.0-pre1 milestone May 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
JRuby 9.0.0.0-pre1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kares @mkristian @headius