Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 1675 on jruby-1_7: String#casecmp on UTF-16LE encoded string #2349

Merged

Conversation

Projects
None yet
2 participants
@k77ch7
Copy link
Contributor

commented Dec 27, 2014

This commit fixes issue #1675 on jruby-1_7 branch. I wrote a rspec test using the available encodings in addition to UTF-16LE. See GH-1675_casecmp_on_UTF16LE_encoded_string_spec.rb for details.

@headius

This comment has been minimized.

Copy link
Member

commented Jan 12, 2015

Looks good.

headius added a commit that referenced this pull request Jan 12, 2015

Merge pull request #2349 from k77ch7/GH-1675_casecmp_on_UTF16LE_encod…
…ed_string

Fix for issue 1675 on jruby-1_7: String#casecmp on UTF-16LE encoded string

@headius headius merged commit 899b638 into jruby:jruby-1_7 Jan 12, 2015

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details

@headius headius added this to the JRuby 9.0.0.0-pre1 milestone Jan 12, 2015

@headius headius self-assigned this Jan 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.