Fixed yielded arrays of 1 element bug when using Enumerator#first #2458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good to get this fixed, but I hope we can figure out a lighter way to do it in the future. If I understand the logic, we're basically double-wrapping the value so that when unwrapped by yield logic it comes out unharmed. Will merge today. |
headius
added a commit
that referenced
this pull request
Jan 14, 2015
Fixed yielded arrays of 1 element bug when using Enumerator#first
|
Ah, ok, so this is the corresponding PR. Sorry, didn't find it at first (hint: you can search for a SHA in Github and it will find the corresponding PR). |
This was referenced Aug 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an old issue #2376 with RubyYielder class.
This fix passes Rubyspecs and MRI specs, however let me know if there any changes required.