Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ascii-only detection of symbol names. #2504

Closed
wants to merge 1 commit into from

Conversation

@cheald
Copy link
Contributor

@cheald cheald commented Jan 23, 2015

If you run the issue described in #1328 with -J-Dfile.encoding=CP1252
then the string length comparison fails. This smoothes over the issue,
but it is still possible that there are problems with bytes being read
with the JVM's file.encoding rather than the encoding specified in the
magic comment.

Closes #1328

If you run the issue described in jruby#1328 with -J-Dfile.encoding=CP1252
then the string length comparison fails. This smoothes over the issue,
but it is still possible that there are problems with bytes being read
with the JVM's file.encoding rather than the encoding specified in the
magic comment.

Closes jruby#1328
@enebo
Copy link
Member

@enebo enebo commented Jan 26, 2015

I would apply this since it would clear up the specific problem reported in #1328, but I am worried if I do then we will wallpaper over the real issue which is getting wrong encoding bytes and feeding them to UTF8 encoding method. So leaving PR open for the time being until I can look at #1328. Once we do find the base case we can apply this since you said this was normative way MRI checks.

Loading

@enebo enebo closed this Nov 2, 2016
@enebo enebo added this to the Invalid or Duplicate milestone Nov 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants