improving building of distribution archives and artifacts #2509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
using the jni libraries only from the jruby.jar would unify things. currently core/ builds jruby-core-noasm, jruby-core-complete and lib/jruby.jar
the ec3e503 reduces it to two jar files
the second commit renames the jruby-core-complete to jruby-core-shaded since the old name people got confused with jruby-complete.jar
this allows to just tell maven to store those shaded jars in lib/ - the shell launcher does work with it including truffle.
this allows to use maven to copy those jars for packing the distribution archives.
finally the naming is consistent whether I see jar on a maven repository or on my jruby-development or from the dist archives or from jruby-jars.gem