Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove exclusion of nonfailing tests #2516

Merged
merged 1 commit into from Jan 26, 2015
Merged

Conversation

@lumeet
Copy link
Contributor

@lumeet lumeet commented Jan 24, 2015

This aims to update test/mri/excludes so that as many tests as possible
are included in the MRI suite.

I wrote a quick script to do the dirty work. Basically, it first de-excludes all tests except some that are known to hang or fail some other way. Then, it runs the test suite and registers errors and failures. Finally, it re-excludes the failing tests. There are some restrictions made, though. No other tests than those tagged with "needs investigation" are touched, for example.

Please, let me know if this strategy is still too aggressive or if there are some obvious flaws.

This aims to update test/mri/excludes so that as many tests as possible
are included in the MRI suite.
enebo added a commit that referenced this issue Jan 26, 2015
Remove exclusion of nonfailing tests.  Perhaps a bit brute force but I only see one failing test on MRI on travis.  Let's roll with it and re-exclude any flaky tests (which I am hoping is the one which is failing on travis).
@enebo enebo merged commit 2c1f22c into jruby:master Jan 26, 2015
1 check failed
Loading
@lumeet lumeet deleted the excluded_tests_cleanup branch Jan 27, 2015
@headius headius added this to the JRuby 9.0.0.0.pre2 milestone May 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants