Remove exclusion of nonfailing tests#2516
Merged
enebo merged 1 commit intojruby:masterfrom Jan 26, 2015
Merged
Conversation
This aims to update test/mri/excludes so that as many tests as possible are included in the MRI suite.
enebo
added a commit
that referenced
this pull request
Jan 26, 2015
Remove exclusion of nonfailing tests. Perhaps a bit brute force but I only see one failing test on MRI on travis. Let's roll with it and re-exclude any flaky tests (which I am hoping is the one which is failing on travis).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aims to update test/mri/excludes so that as many tests as possible
are included in the MRI suite.
I wrote a quick script to do the dirty work. Basically, it first de-excludes all tests except some that are known to hang or fail some other way. Then, it runs the test suite and registers errors and failures. Finally, it re-excludes the failing tests. There are some restrictions made, though. No other tests than those tagged with "needs investigation" are touched, for example.
Please, let me know if this strategy is still too aggressive or if there are some obvious flaws.