Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uninitialized usage of File::Stat #2560

Merged
merged 1 commit into from Feb 5, 2015

Conversation

Projects
None yet
2 participants
@lumeet
Copy link
Contributor

commented Feb 4, 2015

  • Fix File::Stat#struct when uninitialized
  • Make other methods fail nicely unless initialized

The behavior is now the same as in MRI 2.2.

Fix uninitialized usage of File::Stat
* Fix File::Stat#struct when uninitialized
* Make other methods fail unless initialized

@enebo enebo added this to the 9.0.0.0.pre2 milestone Feb 5, 2015

@enebo enebo added the core label Feb 5, 2015

enebo added a commit that referenced this pull request Feb 5, 2015

Merge pull request #2560 from lumeet/uninitialized_file_stat
Fix uninitialized usage of File::Stat

@enebo enebo merged commit 9f9d1f9 into jruby:master Feb 5, 2015

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details
@enebo

This comment has been minimized.

Copy link
Member

commented Feb 5, 2015

@lumeet Is this uninitialized behavior possibly also a bug in our 1.8.7 and 1.9.3 support? If so then this could be done for our jruby-1_7 branch as well.

@lumeet

This comment has been minimized.

Copy link
Contributor Author

commented Feb 6, 2015

@enebo Yes, I submitted a PR for 1.7 too: #2572.

@lumeet lumeet deleted the lumeet:uninitialized_file_stat branch Feb 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.