Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for named captures in StringScanner (fixes #1067) #2603

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@MSNexploder
Copy link
Contributor

commented Feb 16, 2015

test_AREF should pass but fails locally with "undefined method `assert_raise_with_message'" and i'm not sure why. 馃槗

@MSNexploder

This comment has been minimized.

Copy link
Contributor Author

commented Feb 16, 2015

Actually this is my very first pull request for JRuby so...

no idea

@enebo enebo added this to the JRuby 9.0.0.0.rc1 milestone May 1, 2015

@enebo enebo added the JRuby 9000 label May 1, 2015

@enebo

This comment has been minimized.

Copy link
Member

commented May 1, 2015

@MSNexploder ah yeah assert error is because you need to run with test/mri/runner.rb:

/Users/enebo/work/jruby/bin/jruby -X-C -r ./test/mri_test_env.rb test/mri/runner.rb  -q -- ruby/test_alias.rb
@enebo

This comment has been minimized.

Copy link
Member

commented May 1, 2015

@MSNexploder Sorry we left this so long...can you rebase this it no longer applies cleanly...

@MSNexploder

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2015

Actually this pull request is no longer needed. @headius already fixed this in 2d6b3f6.

@MSNexploder MSNexploder closed this May 1, 2015

@MSNexploder MSNexploder deleted the MSNexploder:strscan_captures branch May 1, 2015

@enebo

This comment has been minimized.

Copy link
Member

commented May 1, 2015

@MSNexploder great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.