/ jruby Public
Test load service #2606
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
this adds the missing pieces to avoid the legacy load-service.
the commit with passing the runtime to URLResource is actually not related to the load-service and will fix existing problems.
@ratnikov maybe you have some idea to avoid the double lookup on "." when it is also part of $LOAD_PATH:
Line 135 in a916d45
@headius I reverted the fix you "readded" to make jruby-openssl work on jruby-9k since this is not needed anymore for jruby-openssl-0.9.6. but let me know if support for jruby-openssl-0.9.5 is needed and I will revert the revert.
without legacy load-service there is no need for the https://github.com/jruby/jruby/blob/a916d4563c16b317ccc409dcd12c9a09aede5d85/core/src/main/java/org/jruby/util/CompoundJarURLStreamHandler.java which seems to cause some problems with newer JDK security permissions - see jruby/jruby-openssl#29
before merging I would set the default to use the legacy load-service - to stay as is. but for running travis I used the oposite default.