Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java support cleanup and improvements #2624

wants to merge 45 commits into from


Copy link

@kares kares commented Feb 26, 2015

details at commits .. I'm happy to re-iterate leave some out as needed

…ch are internal

also hidden JavaClass' constructor as if it's ever instantiated outside JavaSupport's class-value cache it will start to break things badly
…son typos

... `obj == NEVER` when really unwrapped value was meant to be compared
…ltiple threads)

avoid warnings such as rb:42 warning: already initialized constant JavaUtilConcurrent

probably related to jruby#2014

... has a desired side effect of improving "initial" performance
due not re-raising ClassNotFoundExceptions within the Ruby runtime

they also will no longer be reported by the runtime with log.exeptions=true
- only pass context to (internal) getTopLevelProxyOrPackage method
- setupJavaClass does not need a java_class argument (it's not used)
- only intern string on addMethod (although it's likely redundat there as well)
…me up the stack

... it very likely never-ever trimmed anything
also (package) "internalized" JavaClass.getRubyArray as toRubyArray
…& also :

- invoke implementation now avoids unnecessary System.arraycopy call
- pre-maturily optimized some from "excessive" getRuntime() invocations
Copy link

headius commented Feb 26, 2015

This has been merged into test-refactor-ji and I'm continuing some refactoring there. Will merge that branch to jruby-1_7 shortly.

@headius headius closed this Feb 26, 2015
@headius headius added this to the JRuby 1.7.20 milestone Feb 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants