[Truffle] Passing through encoding information from SymbolNode #2626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ySymbol. Previously all were encoding as ASCII.
|
There's a FindBugs failure, but I'm not sure it's related. I'm going to merge this and then look into the matter. |
nirvdrum
added a commit
that referenced
this issue
Feb 27, 2015
[Truffle] Passing through encoding information from SymbolNode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
to RubySymbol. Previously all were encoding as ASCII. A few string only methods are here to keep it backward compatible. I wasn't sure how to facture out the method calls to these.
I think SymbolNode could be considered to use ByteList instead of a String in the future.