Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Truffle] Passing through encoding information from SymbolNode #2626

Merged
merged 1 commit into from Feb 27, 2015

Conversation

bjfish
Copy link
Contributor

@bjfish bjfish commented Feb 26, 2015

to RubySymbol. Previously all were encoding as ASCII. A few string only methods are here to keep it backward compatible. I wasn't sure how to facture out the method calls to these.

I think SymbolNode could be considered to use ByteList instead of a String in the future.

…ySymbol. Previously all were encoding as ASCII.
@nirvdrum
Copy link
Contributor

@nirvdrum nirvdrum commented Feb 27, 2015

There's a FindBugs failure, but I'm not sure it's related. I'm going to merge this and then look into the matter.

nirvdrum added a commit that referenced this issue Feb 27, 2015
[Truffle] Passing through encoding information from SymbolNode
@nirvdrum nirvdrum merged commit 7d3ce06 into jruby:master Feb 27, 2015
1 check failed
@chrisseaton chrisseaton added this to the truffle-dev milestone May 4, 2015
@chrisseaton chrisseaton added this to the truffle-dev milestone May 4, 2015
@chrisseaton chrisseaton removed this from the truffle-dev milestone May 4, 2015
@chrisseaton chrisseaton removed this from the truffle-dev milestone May 4, 2015
@chrisseaton chrisseaton added this to the truffle-dev milestone May 4, 2015
@chrisseaton chrisseaton added this to the truffle-dev milestone May 4, 2015
@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants