Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embed internal fixes #2630

Closed
wants to merge 24 commits into from

Conversation

Projects
None yet
1 participant
@kares
Copy link
Member

kares commented Feb 27, 2015

while using JRuby's embed APIs in a slightly more advanced scenarios I run into several issues :

  • BiVariableMap is not behaving as a valid Map instance (throwing NPEs on methods if not used "right")
  • ARGV was mean to be kept (as the map is cleared) but unfortunately not correctly

added some tests covering intended (existing and fixed) functionality. trying to understand the details of context providers (and related embed variable impls) was a bit hard to read thus did clean-up some (helped my brain to process the code).

let me know if smt needs more work, targeting jruby-1_7 - there are no (existing) API incompatibilities ...

kares added some commits Dec 7, 2014

fix, dry and simplify the internals or various local-context-provider…
… impls :

- share the logic of obtaining a global runtime
- when global runtime is used make sure we always return the correct instance config!
- introduce & use LocalContext's internal getRuntime for lazy runtime initialization
- support contructors for all providers without the lazy argument
cleanup SingletonLocalContextProvider for the outside world
correctly synchronize local context setup/teardown (on our class)!
@kares

This comment has been minimized.

Copy link
Member Author

kares commented Apr 14, 2015

rebased and commited on jruby-1_7

@kares kares closed this Apr 14, 2015

@kares kares added this to the JRuby 1.7.20 milestone Apr 14, 2015

@kares kares deleted the test-embed-internal-fixes branch Apr 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.