Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Truffle] Implemented Regexp#match_start for strscan. #2638

merged 6 commits into from
Mar 2, 2015


Copy link

@bjfish bjfish commented Mar 1, 2015

This passes the match_start_spec.rb which isn't in our repo currently:

It would be nice to have more specs for this method to ensure correctness.

Copy link

You can just copy and paste that spec straight into this repo.

Copy link
Contributor Author

bjfish commented Mar 1, 2015

@chrisseaton I'll be updating this to add search_from, I think this match_start is a little off and will update too.

chrisseaton added a commit that referenced this pull request Mar 2, 2015
[Truffle] Implemented Regexp#match_start for strscan.
@chrisseaton chrisseaton merged commit 74028ea into jruby:master Mar 2, 2015
@bjfish bjfish deleted the truffle_strscan branch March 2, 2015 16:25
@chrisseaton chrisseaton modified the milestone: truffle-dev May 4, 2015
@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants