Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Truffle] Adding Array#repeated_permutations to array.rb #2680

merged 3 commits into from
Mar 11, 2015


Copy link

@bjfish bjfish commented Mar 10, 2015

Is recursive ruby code okay?

Copy link
Contributor Author

bjfish commented Mar 11, 2015

Is it okay for me to replace your Array#rindex shim? @nirvdrum Should I do Array#reverse too?

Copy link

Yes it's generally good to replace shim methods with real implementations.

chrisseaton added a commit that referenced this pull request Mar 11, 2015
[Truffle] Adding Array#repeated_permutations to array.rb
@chrisseaton chrisseaton merged commit 061fae7 into jruby:master Mar 11, 2015
@chrisseaton chrisseaton added this to the truffle-dev milestone Mar 11, 2015
Copy link

Feel free to replace the Array#reverse shim. I did it this way because the Rubinius definition doesn't pull in cleanly. It seems like something that might be better served in Java anyway. But have at it either way.

@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants