[Truffle] - Initial implementation of Ruby Random class. #2682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,177 @@ | |||
| # | |||
| # Extracted from https://github.com/rubinius/rubinius/blob/v2.4.1/kernel/common/random.rb | |||
| # | |||
There was a problem hiding this comment.
This needs to be the full Rubinius license. Can you copy from another file in common?
There was a problem hiding this comment.
For sure. give me a minute.
lucasallan
force-pushed
the
random-class
branch
from
e86587c
to
8c59aae
Compare
| @@ -0,0 +1,203 @@ | |||
| # Copyright (c) 2007-2014, Evan Phoenix and contributors | |||
lucasallan
force-pushed
the
random-class
branch
from
8c59aae
to
f06c21e
Compare
| } | ||
|
|
||
| @Specialization | ||
| public Long randomizerSeed(RubyBasicObject random) { |
|
It looks like you've gotten the idea of how to import code form Rubinius - but you have some failures in the core specs and FindBugs - see the Travis report. Also, maybe you were doing a trivial initial implementation, but you actually need to implement a PRNG using the seed in the randomiser primitives. |
lucasallan
force-pushed
the
random-class
branch
5 times, most recently
from
d49952c
to
d21619d
Compare
|
Just waiting for Travis to finish... |
chrisseaton
added a commit
that referenced
this pull request
Mar 13, 2015
[Truffle] - Initial implementation of Ruby Random class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @chrisseaton @nirvdrum could you guys take a look?
Thanks!