Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implements strict base64 encoding #2715

Merged
merged 1 commit into from Mar 19, 2015

Conversation

Projects
None yet
2 participants
@mkristian
Copy link
Member

mkristian commented Mar 17, 2015

apparently the respective tests were excluded.

@headius could have a look - there is a lot of "duplication" but did not know how to avoid it. if this patch is OK I will also merge it to master.

implements strict base64 encoding
apparently the respective tests were excluded.

Sponsored by Lookout Inc.

@mkristian mkristian force-pushed the strict-base64-encoding branch from 9a88ecf to 13ff7bf Mar 18, 2015

@headius

This comment has been minimized.

Copy link
Member

headius commented Mar 18, 2015

👍 Looks good.

mkristian added a commit that referenced this pull request Mar 19, 2015

Merge pull request #2715 from jruby/strict-base64-encoding
implements strict base64 encoding

@mkristian mkristian merged commit aabe84c into jruby-1_7 Mar 19, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mkristian mkristian deleted the strict-base64-encoding branch Mar 19, 2015

@headius headius added this to the JRuby 1.7.20 milestone May 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.