[Truffle] Implementing more of Array#pop. #2737
Conversation
|
@nirvdrum @chrisseaton Is this much code repetition normal to get things implemented right now? |
|
Array is a bit odd in having so many specialized stores, but looking at what you have, a fair bit could be pushed to a private helper method. |
bjfish
force-pushed
the
truffle_array_pop
branch
from
389507d
to
29d4bae
Compare
|
Yeah - the duplication here is pretty bad. What I think we will do is allocate an interface that hides the type, inside each specialisation, and hand that to a helper method. With PE the interface will compile away and we should get the same code. However I'd rather do a little bit of repetitive messy code while we work through the specs, and then at the end step back and think about what to de-duplicate. |
|
|
||
| @Specialization(guards = "isFloat", rewriteOn = UnexpectedResultException.class) | ||
| public RubyArray popFloatInBoundsWithNum(VirtualFrame frame, RubyArray array, int num) throws UnexpectedResultException { | ||
| if(num < 0){ |
There was a problem hiding this comment.
Really sorry to be so pedantic, but this should be if (num < 0) {, with the spaces in there.
There was a problem hiding this comment.
@chrisseaton Fixed it at 412f0ad
[Truffle] Implementing more of Array#pop.
No description provided.