[Truffle] Don't taint from self in String#[](String). #2780
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chrisseaton @eregon This is one of the proposed solutions for dealing with the need to skip tainting for certain specializations. I don't particularly like using exceptions this way, but using a wrapper object would likely add much greater overhead. The third alternative is to not use the CoreMethod option for tainting at all, but rather have each specialization that needs it use the
TaintResultNode
in place; this seems both error-prone (easy to forget one) and verbose.I'm doing this as a PR to get feedback. No hard feelings if you think this is terrible.