Skip to content

Fix typo in error message#2875

Merged
mkristian merged 1 commit into
jruby:masterfrom
jkutner:patch-1
Apr 26, 2015
Merged

Fix typo in error message#2875
mkristian merged 1 commit into
jruby:masterfrom
jkutner:patch-1

Conversation

@jkutner

@jkutner jkutner commented Apr 25, 2015

Copy link
Copy Markdown
Member

No description provided.

@jkutner

jkutner commented Apr 25, 2015

Copy link
Copy Markdown
Member Author

This could be a problem for warbler's runnable feature, which uses file: path for jruby home :/

mkristian added a commit that referenced this pull request Apr 26, 2015
Fix typo in error message
@mkristian mkristian merged commit 6213244 into jruby:master Apr 26, 2015
@mkristian

Copy link
Copy Markdown
Member

@jkutner did you see the error message on warbler ? if so there is no problem to remove this message IMO

@jkutner

jkutner commented Apr 26, 2015

Copy link
Copy Markdown
Member Author

@mkristian it seemed to "work" with the file:/path/to/jar/... prefix. But I was able to remove the warning by replace it with uri:classloader:!/META-INF/...

I say "work" because I'm stuck against another problem where Gem::Specification is returning uri:classloader:... for the executable script, but RubyInstanceConfig.getScriptSource() doesn't handle it.

@mkristian

Copy link
Copy Markdown
Member

I am happy to see that "uri:classloader:" works everywhere. but I am not sure where and how this RubyInstanceConfig.getScriptSource(). could give me a bit more input. maybe we should continue this on new issue or so

@jkutner

jkutner commented Apr 26, 2015

Copy link
Copy Markdown
Member Author

here: #2876

@headius headius added this to the JRuby 9.0.0.0.pre2 milestone May 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants