Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mimic MRI's openssl when jopenssl require fails. #2894

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@voxik
Copy link
Contributor

voxik commented Apr 30, 2015

Some libraries (such as RubyGems [1]) rescues openssl load errors and
adjusts their behavior depending if the openssl is properly required.
However, prior this commit, require 'openssl' succeeded just fine, but
the subsequent requires failed, which makes RubyGems (and similar) to
fail unexpectedly.

[1] https://github.com/rubygems/rubygems/blob/master/lib/rubygems/security.rb#L14

Mimic MRI's openssl when jopenssl require fails.
Some libraries (such as RubyGems) rescues openssl load errors and
adjusts their behavior depending if the openssl is properly required.
However, prior this commit, require 'openssl' succeeded just fine, but
the subsequent requires failed, which makes RubyGems (and similar) to
fail unexpectedly.
@mkristian

This comment has been minimized.

Copy link
Member

mkristian commented Apr 30, 2015

that this file 'openssl.rb' is in the jruby repo is probably not right. investigating . . .

mkristian added a commit that referenced this pull request Apr 30, 2015

@mkristian

This comment has been minimized.

Copy link
Member

mkristian commented Apr 30, 2015

as I thought any change in this file will be overwritten by the one we import during the build from jruby-openssl.gem

@mkristian mkristian closed this Apr 30, 2015

@mkristian

This comment has been minimized.

Copy link
Member

mkristian commented Apr 30, 2015

@voxik so any change in jruby-openssl will reflect on jruby. so next jruby-openssl version might have your patch.

@voxik

This comment has been minimized.

Copy link
Contributor Author

voxik commented Apr 30, 2015

Perfect, thanks :)

@headius headius added this to the JRuby 1.7.20 milestone May 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.