Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 2896 on master : Symbol#inspect with utf8 encode string #2899

Merged
merged 1 commit into from May 1, 2015

Conversation

Projects
None yet
2 participants
@k77ch7
Copy link
Contributor

k77ch7 commented Apr 30, 2015

This commit fixes issue #2896 on master and closes #2713.
This patch is partial ports of the MRI rb_str_symname_p and rb_enc_symname_p.
Please review, @enebo. If this patch is OK, I also hope that this patch is applied to 1_7 branch.

Thanks!

@enebo enebo added this to the JRuby 9.0.0.0.rc1 milestone May 1, 2015

@enebo enebo added the core label May 1, 2015

enebo added a commit that referenced this pull request May 1, 2015

Merge pull request #2899 from k77ch7/fix_GH-2896_on_master
Fix for issue 2896 on master : Symbol#inspect with utf8 encode string

@enebo enebo merged commit e9d8a47 into jruby:master May 1, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@enebo

This comment has been minimized.

Copy link
Member

enebo commented May 1, 2015

@k77ch7 I wondered about this little snippet:

!(c < 128))

I would have wrote it as c >= 128 but it is fine this way as well.

@enebo

This comment has been minimized.

Copy link
Member

enebo commented May 1, 2015

I applied this to jruby-1_7 as well...thanks again!

@k77ch7

This comment has been minimized.

Copy link
Contributor Author

k77ch7 commented May 3, 2015

I agree with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.