Fix for issue #276 #293

Closed
wants to merge 1 commit into
from

2 participants

@tychobrailleur

This commit fixes issue #276 which is a regression introduced by
http://jira.codehaus.org/browse/JRUBY-6729. The bug was caused by a erroneous
behaviour when yielding splat for a block of arity of one: MRI doesn't unsplat
the passed value, whilst jruby was.

See GH-276_yield_splat_behaviour_causes_pp_to_break.rb for details on behaviour when yielding splat.

@tychobrailleur tychobrailleur Fix for issue #276
This commit fixes issue #276 which is a regression introduced by
http://jira.codehaus.org/browse/JRUBY-6729.  The bug was caused by a erroneous
behavour when yielding splat for a block of arity of one: MRI doesn't unsplat
the passed value, whilst jruby was.

See GH-276_yield_splat_behaviour_causes_pp_to_break.rb for details on behaviour
a2c6561
@tychobrailleur

This restores the behaviour prior to JRUBY-6729

@headius
JRuby Team member

A-ha! Very good! I was hoping to find a fix for this issue. I'll have a look and get it merged if it's ok.

@headius headius added a commit that closed this pull request Sep 18, 2012
@headius headius Additional fix to go with #276 and its fix #293.
* Compiler needed the same logic.
* Invalid block needs to be checked or arity().getValue will NPE.
da2a9dd
@headius headius closed this in da2a9dd Sep 18, 2012
@prathamesh-sonpatki prathamesh-sonpatki pushed a commit to prathamesh-sonpatki/jruby that referenced this pull request Sep 18, 2012
@headius headius Additional fix to go with #276 and its fix #293.
* Compiler needed the same logic.
* Invalid block needs to be checked or arity().getValue will NPE.
dc19d5d
@prathamesh-sonpatki prathamesh-sonpatki pushed a commit to prathamesh-sonpatki/jruby that referenced this pull request Sep 21, 2012
@headius headius Additional fix to go with #276 and its fix #293.
* Compiler needed the same logic.
* Invalid block needs to be checked or arity().getValue will NPE.
a0441ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment