Fix for issue #276 #293

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@tychobrailleur

This commit fixes issue #276 which is a regression introduced by
http://jira.codehaus.org/browse/JRUBY-6729. The bug was caused by a erroneous
behaviour when yielding splat for a block of arity of one: MRI doesn't unsplat
the passed value, whilst jruby was.

See GH-276_yield_splat_behaviour_causes_pp_to_break.rb for details on behaviour when yielding splat.

@tychobrailleur tychobrailleur Fix for issue #276
This commit fixes issue #276 which is a regression introduced by
http://jira.codehaus.org/browse/JRUBY-6729.  The bug was caused by a erroneous
behavour when yielding splat for a block of arity of one: MRI doesn't unsplat
the passed value, whilst jruby was.

See GH-276_yield_splat_behaviour_causes_pp_to_break.rb for details on behaviour
a2c6561
@tychobrailleur

This restores the behaviour prior to JRUBY-6729

@headius
JRuby Team member

A-ha! Very good! I was hoping to find a fix for this issue. I'll have a look and get it merged if it's ok.

@headius headius added a commit that closed this pull request Sep 18, 2012
@headius headius Additional fix to go with #276 and its fix #293.
* Compiler needed the same logic.
* Invalid block needs to be checked or arity().getValue will NPE.
da2a9dd
@headius headius closed this in da2a9dd Sep 18, 2012
@prathamesh-sonpatki prathamesh-sonpatki pushed a commit to prathamesh-sonpatki/jruby that referenced this pull request Sep 18, 2012
@headius headius Additional fix to go with #276 and its fix #293.
* Compiler needed the same logic.
* Invalid block needs to be checked or arity().getValue will NPE.
dc19d5d
@prathamesh-sonpatki prathamesh-sonpatki pushed a commit to prathamesh-sonpatki/jruby that referenced this pull request Sep 21, 2012
@headius headius Additional fix to go with #276 and its fix #293.
* Compiler needed the same logic.
* Invalid block needs to be checked or arity().getValue will NPE.
a0441ff
@eregon eregon added a commit that referenced this pull request Sep 27, 2016
@eregon eregon Squashed 'spec/ruby/' changes from ffdfa41..ae9cea3
ae9cea3 Guard File.setgid? spec for superuser.
486bd3d Specs for reopening class/module private constant.
0e019a5 Show the exit status when compilation failed
2fdf80d Spec for high-precision BigMath.log on a Rational.
c37bf53 define_method should modify the visibility of an UnboundMethod.
a93fdab Add spec asserting that Kernel#` lets stderr through
c2c3091 Improve formatting
651dfd1 Add a spec for jruby/jruby#2376
f24a00f Expose two Enumerator-related bugs
d05fabf Avoid File.split in require specs
2c791fb Use expand_path/realpath with a directory base
9daa861 Fix running a spec file directly:
2300e4c Merge pull request #293 from iliabylich/add-test-case-for-time-to_i
3cd1560 Added test case for non-zero Time#to_i.
f0548a9 getsockopt(2) may retuns SO_LINGER instead of 1
f6793fa Merge pull request #291 from etehtsea/improve-setsockopt-specs
5712b54 Add Socket::Option as arg specs to setsockopt
7f21c2c Merge pull request #290 from etehtsea/improve-unpack-pack-sockaddr
16ac165 Improve Socket.(pack_)sockaddr_un specs
19c28c3 Fix pack_sockaddr shared spec
dddcf78 Add Socket.unpack_sockaddr_un specs
8bdec12 Improve Socket.unpack_sockaddr_in specs

git-subtree-dir: spec/ruby
git-subtree-split: ae9cea38bdbeddaf16968ddc311f8ca6c481fca2
0eede44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment