Create Truffle specific main function. #3066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. A couple of general comments:
/*
* Copyright (c) 2015 Oracle and/or its affiliates. All rights reserved. This
* code is released under a tri EPL/GPL/LGPL license. You can use it,
* redistribute it and/or modify it under the terms of the:
*
* Eclipse Public License version 1.0
* GNU General Public License version 2
* GNU Lesser General Public License version 2.1
*/@enebo @headius this simpler Truffle-specifc |
Change tabs to spaces and capitalize comments.
chrisseaton
added a commit
that referenced
this pull request
Jun 18, 2015
[Truffle] Create Truffle specific main function.
| .parseFromMain(filename, in); | ||
|
|
||
| // If no DATA, we're done with the stream, shut it down | ||
| if (runtime.fetchGlobalConstant("DATA") == null) { |
There was a problem hiding this comment.
Yeah I went back and fixed.
There was a problem hiding this comment.
Fixed by @chrisseaton in a later commit.
|
I'll address my comments in a commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.