Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date.rewrite_frags #3119

Closed
wants to merge 1 commit into from
Closed

Conversation

@skmp
Copy link
Contributor

@skmp skmp commented Jul 8, 2015

According to MRI, offset should be preserved and
added to the seconds.

Fixes #2149

For reference, https://github.com/ruby/ruby/blob/39051ba1b94c61e92f333e514982c8f1333c7223/ext/date/date_core.c#L3682.

DateTime.strptime ignored timezone offsets when initialized via seconds, which is the cause of the test fail on #2149. If offset is dropped, the timezone information is lost.

According to MRI, offset should be preserved and
added to the seconds.

Fixes #2149
@kares
Copy link
Member

@kares kares commented Nov 13, 2015

your commit landed on master as: a0b6eda ... thanks for back-porting this.

@kares kares closed this Nov 13, 2015
@kares kares added this to the JRuby 9.0.5.0 milestone Nov 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants