Correct a format string in Signal#trap. #3209

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
4 participants
@Freaky
Contributor

Freaky commented Aug 1, 2015

Fixes #3208: Trapping reserved signals doesn't print a meaningful
message

Correct a format string in Signal#trap.
Fixes #3208: Trapping reserved signals doesn't print a meaningful
message
@rtyler

This comment has been minimized.

Show comment
Hide comment
@rtyler

rtyler Aug 2, 2015

The failure below from Travis doesn't look related, but would it be possible to add a test to ensure that #3208 is really fixed?

     [exec] 
     [exec] Failures:
     [exec] 
     [exec]   1) FFI::Function can wrap a blocking function
     [exec]      Failure/Error: expect(Time.now - time).to be >= 2
     [exec]      NameError:
     [exec]        uninitialized constant RSpec::Matchers::BuiltIn::Be
     [exec]      # ./spec/ffi/function_spec.rb:71:in `block in (root)'
     [exec] 
     [exec] Finished in 21.64 seconds
     [exec] 4843 examples, 1 failure
     [exec] 
     [exec] Failed examples:
     [exec] 
     [exec] rspec ./spec/ffi/function_spec.rb:65 # FFI::Function can wrap a blocking function

rtyler commented Aug 2, 2015

The failure below from Travis doesn't look related, but would it be possible to add a test to ensure that #3208 is really fixed?

     [exec] 
     [exec] Failures:
     [exec] 
     [exec]   1) FFI::Function can wrap a blocking function
     [exec]      Failure/Error: expect(Time.now - time).to be >= 2
     [exec]      NameError:
     [exec]        uninitialized constant RSpec::Matchers::BuiltIn::Be
     [exec]      # ./spec/ffi/function_spec.rb:71:in `block in (root)'
     [exec] 
     [exec] Finished in 21.64 seconds
     [exec] 4843 examples, 1 failure
     [exec] 
     [exec] Failed examples:
     [exec] 
     [exec] rspec ./spec/ffi/function_spec.rb:65 # FFI::Function can wrap a blocking function

@rtyler rtyler added the JRuby 9000 label Aug 2, 2015

@Freaky

This comment has been minimized.

Show comment
Hide comment
@Freaky

Freaky Aug 2, 2015

Contributor

Certainly. Shall I just add a new test to RubySpec?

Contributor

Freaky commented Aug 2, 2015

Certainly. Shall I just add a new test to RubySpec?

@dirk

This comment has been minimized.

Show comment
Hide comment
@dirk

dirk Aug 3, 2015

Contributor

@Freaky: I'm guessing it should be added to the MRI TestSignal test case in this file.

Contributor

dirk commented Aug 3, 2015

@Freaky: I'm guessing it should be added to the MRI TestSignal test case in this file.

@Freaky

This comment has been minimized.

Show comment
Hide comment
@Freaky

Freaky Aug 3, 2015

Contributor

Did both.

Contributor

Freaky commented Aug 3, 2015

Did both.

@kares kares added this to the JRuby 9.0.5.0 milestone Nov 13, 2015

@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares Nov 13, 2015

Member

picked the fix and test as 18df48a and 0adaddf on master ... Thanks Thomas!

Member

kares commented Nov 13, 2015

picked the fix and test as 18df48a and 0adaddf on master ... Thanks Thomas!

@kares kares closed this Nov 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment