Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct a format string in Signal#trap. #3209

Closed
wants to merge 4 commits into from
Closed

Conversation

@Freaky
Copy link
Contributor

Freaky commented Aug 1, 2015

Fixes #3208: Trapping reserved signals doesn't print a meaningful
message

Fixes #3208: Trapping reserved signals doesn't print a meaningful
message
@rtyler
Copy link

rtyler commented Aug 2, 2015

The failure below from Travis doesn't look related, but would it be possible to add a test to ensure that #3208 is really fixed?

     [exec] 
     [exec] Failures:
     [exec] 
     [exec]   1) FFI::Function can wrap a blocking function
     [exec]      Failure/Error: expect(Time.now - time).to be >= 2
     [exec]      NameError:
     [exec]        uninitialized constant RSpec::Matchers::BuiltIn::Be
     [exec]      # ./spec/ffi/function_spec.rb:71:in `block in (root)'
     [exec] 
     [exec] Finished in 21.64 seconds
     [exec] 4843 examples, 1 failure
     [exec] 
     [exec] Failed examples:
     [exec] 
     [exec] rspec ./spec/ffi/function_spec.rb:65 # FFI::Function can wrap a blocking function
@rtyler rtyler added the JRuby 9000 label Aug 2, 2015
@Freaky
Copy link
Contributor Author

Freaky commented Aug 2, 2015

Certainly. Shall I just add a new test to RubySpec?

@dirk
Copy link
Contributor

dirk commented Aug 3, 2015

@Freaky: I'm guessing it should be added to the MRI TestSignal test case in this file.

@Freaky
Copy link
Contributor Author

Freaky commented Aug 3, 2015

Did both.

@kares kares added this to the JRuby 9.0.5.0 milestone Nov 13, 2015
@kares
Copy link
Member

kares commented Nov 13, 2015

picked the fix and test as 18df48a and 0adaddf on master ... Thanks Thomas!

@kares kares closed this Nov 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.